Adds Warnings for running a deprecated or an internal module main function #5146
+158
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"squashes" work done by Lioncat2002 in pull request gleam-lang#4283
kfc35
changed the title
kfc35
commented
Nov 20, 2025
| // warning_emitter.emit also increments a counter. However, we only want to | ||
| // increment that counter for root package warnings. For dependencies, | ||
| // we just print the warning directly to console. | ||
| match package_kind { |
Author
There was a problem hiding this comment.
just highlighting this section to see if this logic is correct re: warning emitter usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #4283
Closes #2569
To resolve some loose threads from the previous pull request’s comments:
mod_config(produced fromfind_package_config_for_moduleorroot_config) to test whether a module is internal, so I removed the newis_internalfunction the previous author put in and was suggested in the initial task discussion. Let me know if this is not the right way to go about it and the original comment was correct.WarningEmitterused that manages the counter for the number of warnings as asked for and interpreted by me. I think I did this correctly, but if I misinterpreted this request or its usage, please let me know.I’m very new to Rust and Gleam, so apologies in advance if something is completely off base.
I would be curious to know how I can test any compiler changes locally and manually with a Gleam project. If there is documentation somewhere, please share.